This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Implemented WingsailController Class #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DFriend01
suggested changes
Feb 18, 2024
|
@evannawfal Please change the title of the PR to something more descriptive. This is the message that shows up in the commit history in the main branch, so it needs to be descriptive enough for others to have a high-level understanding of what this PR was for. |
evannawfal
changed the title
DFriend01
suggested changes
Mar 4, 2024
Comment on lines
+60
to
+62
| def get_trim_tab_angle( | ||
| self, apparent_wind_speed: float, apparent_wind_direction: float | ||
| ) -> float: |
There was a problem hiding this comment.
I recommend overloading this function where you accept the apparent wind vector, calculate the wind speed and direction, and then call this function to get the trim tab angle.
There was a problem hiding this comment.
Let's hold off doing this until we figured out the angle convention.
|
We want to change the angle convention as per our conversation, but let's leave that in another issue |
…il-Controller-Class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made a Wingsail Controller class and a class for testing as well.
Verification
Created tests to validate functionality.
Resources
#20