Use primaryColor for status bar color #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@all-contributors please add @nortio for code |
|
Thanks |
|
I've put up a pull request to add @nortio! 🎉 |
Tobi823
added a commit
that referenced
this pull request
Jun 30, 2024
- Thanks nortio for fixing primaryColor for status bar color (#609) - Thanks Andrew Gunnerson (chenxiaolong) for setting "update ownership" when installing a new app (#591) - Thanks for the Weblate contributions from: Priit Jõerüüt, Cirnos, Coool (github.com/Coool), Retrial, Flavio F. M., gallegonovato, Scrambled777, 大王叫我来巡山, Kazushi Hayama, Giovanni Donisi, Kirill Isakov, 109247019824 - Dont check for updates / don't download updates when power save mode is enabled - Dont use OkHttp to cache network responses, use custom data structure - Try to fix download timeouts by increasing OkHttp timeout thresholds - Try to fix bug by initialize WorkManager if it is not initialized (#586)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes in my opinion an annoying visual issue:
The status bar color does not match the app bar color. While I believe this is not intentional, in the case that it is it should at least be corrected to a color with better contrast with the status bar text.
This is now the result after the fix (also works in light mode):
There seems to be the same problem in the settings page but I did not fix it.