Add support for requesting update ownership on Android 14+ #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your work. I will look into it. Maybe I need a few days. |
|
Notes for me: When I use setRequestUpdateOwnership and update an app with another store:
To revoke the update ownership, I have to uninstall FFUpdater (deleting storage is not enough) |
|
I think it is better not to offer the option to enable/disable update ownership enforcement for installed apps because:
I will change your PR in the next days and then merge it. |
|
Sure, that makes sense. If it makes it any easier, I can update this PR to remove the option and always enable update ownership for Android 14+. EDIT: Done |
chenxiaolong
force-pushed
the
update_ownership
branch
from
e1d24b8
to
94abf63
Compare
If update ownership is requested during the initial install (it is a no-op for updates), then other app stores are not allowed to update the app without explicit user action. This stops Google Play from updating Firefox because the versionCode of the APKs published there are always higher. Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
force-pushed
the
update_ownership
branch
from
94abf63
to
e39f324
Compare
|
Thanks |
|
@all-contributors please add @chenxiaolong for code |
|
I've put up a pull request to add @chenxiaolong! 🎉 |
Tobi823
added a commit
that referenced
this pull request
Jun 30, 2024
- Thanks nortio for fixing primaryColor for status bar color (#609) - Thanks Andrew Gunnerson (chenxiaolong) for setting "update ownership" when installing a new app (#591) - Thanks for the Weblate contributions from: Priit Jõerüüt, Cirnos, Coool (github.com/Coool), Retrial, Flavio F. M., gallegonovato, Scrambled777, 大王叫我来巡山, Kazushi Hayama, Giovanni Donisi, Kirill Isakov, 109247019824 - Dont check for updates / don't download updates when power save mode is enabled - Dont use OkHttp to cache network responses, use custom data structure - Try to fix download timeouts by increasing OkHttp timeout thresholds - Try to fix bug by initialize WorkManager if it is not initialized (#586)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If update ownership is requested during the initial install (it is a no-op for updates), then other app stores are not allowed to update the app without explicit user action. This stops Google Play from updating Firefox because the versionCode of the APKs published there are always higher.
The feature is disabled by default and is hidden if the device is running older versions of Android or if the installer method is not the session installer.EDIT: No longer optionalScreenshot of Google Play's page for Firefox when this option is used: Screenshot_20240525-113105. Firefox also no longer shows up in Google Play's pending updates list.