-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1298: Setup for animation model. #1323
base: master
Are you sure you want to change the base?
Conversation
Admin for gloss animation, migration for models.
Worked in PyCharm runserver, but not on real server.
Hi @susanodd , I understand the display of the animation is not on the detail, but is there a reason the upload is not part of the detail view either? Perhaps they could both be in a new tab? |
I purposely did them separate because a lot of functionality is still missing. You can see the animations in the admin. That works. I agree, it could show the animation on the same as the upload. Except I don't know how to display a single animation yet! (The one that was uploaded.) |
Added animation tab https://signbank-test.cls.ru.nl/dictionary/gloss/1462 That has been modified to use the Babylon pre-fab Viewer (a one-liner) to display a glb animation. I spent oodles of time trying to get the demo code to work. For time usage on our side, it would be economical to just use the Babylon Viewer and also include an upload for the glb format, and/or install the conversion software on the server. (I.e., like for video conversion). Some of the sample glb files on the GitHub look transparent (The guy with glasses and the pineapple look okay, but not the others.) |
https://cadexchanger.com/fbx-to-glb/
As an alternative, this, open source: https://github.com/KhronosGroup/glTF/tree/main/specification/2.0 This format can also be displayed by the Babylon Viewer (one-liner in the template). |
I think we need to install a converter, because the fbx is proprietary. Or add the glTF to the model. We shouldn't be using a proprietary file structure.
https://github.com/godotengine/FBX2glTF
https://www.npmjs.com/package/fbx2gltf https://github.com/facebookincubator/FBX2glTF?tab=readme-ov-file#building-it-on-your-own |
That's not needed, we have GLB files already. |
I found this in the github code:
|
Hey @susanodd , this is an open pull request and my review is requested, but the comments suggest this feature is still being designed. To avoid confusion, and reviewing code that will later be deleted, would you agree to only create pull requests for features (or if it's really large, parts of features) that are ready from your point of view? Thanks :) No need to delete this one, but I'll make it a draft. Feel free to 'undraft' whenever you feel it's ready! |
This comment was marked as outdated.
This comment was marked as outdated.
This branch has been removed from signbank-test temporarily. |
[THIS IS NOT ON signbank-test at the moment, it is waiting for another pull request using that branch.]
Links:
https://signbank-test.cls.ru.nl/dictionary/animation/add/
https://signbank-test.cls.ru.nl/dictionary/animation/1
https://signbank-test.cls.ru.nl/dictionary/gloss/1462
The third link shows the Animations tab for a Gloss.
The second link should be displaying the animation for APPEL-A, uploaded in the first link.
But at the moment, it is displaying the "demo" code, which has been included on signbank. (See changed files.)
The display code needs to be modified so that is uses
instead of
/writable/MeshesAndAnims/
or the corresponding fbx files it gets from Sign Collect.TO DO
display just one animation
new page to dynamically create animation sequence (what the demo does)