api: Require non-void change address in /fund

SiaFoundation · Nov 27, 2023 · 607337e · 607337e
1 parent 5c9bb25
commit 607337e
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/api/server.go b/api/server.go
@@ -376,6 +376,9 @@ func (s *server) walletsFundHandler(jc jape.Context) {
 		if outputSum.Cmp(amount) < 0 {
 			return nil, errors.New("insufficient balance")
 		} else if outputSum.Cmp(amount) > 0 {
+			if changeAddr == types.VoidAddress {
+				return nil, errors.New("change address must be specified")
+			}
 			txn.SiacoinOutputs = append(txn.SiacoinOutputs, types.SiacoinOutput{
 				Value:   outputSum.Sub(amount),
 				Address: changeAddr,
@@ -446,6 +449,9 @@ func (s *server) walletsFundSFHandler(jc jape.Context) {
 		if outputSum < amount {
 			return nil, errors.New("insufficient balance")
 		} else if outputSum > amount {
+			if changeAddr == types.VoidAddress {
+				return nil, errors.New("change address must be specified")
+			}
 			txn.SiafundOutputs = append(txn.SiafundOutputs, types.SiafundOutput{
 				Value:   outputSum - amount,
 				Address: changeAddr,