-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State Route #543
Merged
Merged
State Route #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
force-pushed
the
pj/state-route
branch
from
August 11, 2023 10:38
6c2dab9
to
e1acdff
Compare
…o pj/state-route
peterjan
force-pushed
the
pj/state-route
branch
from
August 14, 2023 07:53
bb525f9
to
4f161f6
Compare
…o pj/state-route
…o pj/state-route
peterjan
force-pushed
the
pj/state-route
branch
from
August 18, 2023 08:08
22221f3
to
9c41076
Compare
ChrisSchinnerl
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
/state
route to every service/component to mimichostd
as requested by #521. It will allow providing useful build information in the tooltip and in general is just a useful route to have. It's unfortunate the autopilot already had a/status
endpoint. I copied the information into/state
and I think we should phase out its usage and then deprecate the route entirely.fixes #521