Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update tooltip to include version information #521

Closed
new0nebit opened this issue Aug 7, 2023 · 9 comments · Fixed by #543
Closed

UI: Update tooltip to include version information #521

new0nebit opened this issue Aug 7, 2023 · 9 comments · Fixed by #543
Labels
enhancement New feature or request

Comments

@new0nebit
Copy link

Describe the bug

In renterd I badly miss a tooltip about what version of renterd I have running, similar to the message hint as in hostd.

Expected behaviour

version
@alexfreska
Copy link
Member

Agreed, would be great to match hostd. @peterjan the information is powered by this hostd endpoint: https://api.sia.tech/hostd#32ef7651-c2c1-43c6-89d3-f17c188b4667 we could do a similar one on renterd minus public key.

@peterjan peterjan self-assigned this Aug 11, 2023
@peterjan peterjan mentioned this issue Aug 11, 2023
@peterjan peterjan reopened this Aug 18, 2023
@peterjan peterjan added the ui label Aug 18, 2023
@peterjan
Copy link
Member

peterjan commented Aug 18, 2023

This just got merged into master so it can be incorporated in the UI. It would be nice to get rid of autopilot/status in favor of autopilot/state, I marked the route as deprecated but if we got rid of it in the UI I would like to remove it from the codebase entirely

@peterjan peterjan added the enhancement New feature or request label Aug 18, 2023
@peterjan peterjan removed their assignment Aug 18, 2023
@new0nebit
Copy link
Author

Now tooltip is completely broken in Zen testnet. The tooltip informs that renterd is running in mainnet, but renterd is running in Zen. I also don't see the renterd version. Sorry, I don't get it, has it been added or is it still in the plans and under development?

Screenshot 2023-08-18 в 21 38 32

@alexfreska
Copy link
Member

@new0nebit hey there sorry about that, the master branch can be unstable sometimes do to the need for UI dependencies to be merged. I am not sure why it says mainnet there, but regardless, I have UI changes that totally update the way the network is displayed and also add the version info. We can keep this open until the UI changes make it into renterd. Thank you for your patience! 🙏🏼 SiaFoundation/web#353

@alexfreska
Copy link
Member

@new0nebit should be fixed by #563

@new0nebit
Copy link
Author

@alexfreska Great! However, the tooltip still incorrectly indicates which environment renterd is running in. In my case, renterd is running in Zen, but the tooltip still states that renterd is launched in the Mainnet. I also noticed that the large orange banner in the header with the message "You are on the Zen Testnet." has disappeared.

Screenshot

@alexfreska
Copy link
Member

alexfreska commented Aug 23, 2023

@new0nebit arg, very odd. @peterjan the UI expects these values

renterd/build/network.go

Lines 19 to 22 in c562e69

case "mainnet":
return "Mainnet"
case "zen":
return "Zen Testnet"
I just did a testnet build locally and it does seem to return "Mainnet", is it possible there is an issue on the daemon side?

@alexfreska
Copy link
Member

@new0nebit this should now be fixed: #568

@new0nebit
Copy link
Author

@alexfreska Fixed! Closed 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants