-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(contracts): support rhp4 #507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
previously approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rhp2 "go.sia.tech/core/rhp/v2"
proto4 "go.sia.tech/core/rhp/v4"
rhp4 "go.sia.tech/coreutils/rhp/v4"
I love that this makes total sense
ChrisSchinnerl
previously approved these changes
Nov 19, 2024
n8maninger
dismissed stale reviews from ChrisSchinnerl and peterjan
via
November 20, 2024 17:05
d32aa30
n8maninger
force-pushed
the
nate/refactor-contract-manager
branch
from
November 20, 2024 22:26
d32aa30
to
549838d
Compare
…ditional contract tests for sqlite
n8maninger
force-pushed
the
nate/refactor-contract-manager
branch
from
November 20, 2024 22:27
549838d
to
f45da04
Compare
n8maninger
changed the title
Refactor contract manager
(refactor) contract manager to support rhp4
Nov 20, 2024
n8maninger
changed the title
(refactor) contract manager to support rhp4
refactor(contracts): support rhp4
Nov 20, 2024
peterjan
approved these changes
Nov 22, 2024
ChrisSchinnerl
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the contract manager to match the interface expected by the RHP4 server
Taken from #490