Add missing account-related errors for rhp4 #121
Closed
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
commented
Nov 22, 2024
rhp/v4/server.go
Outdated
| @@ -28,6 +28,11 @@ const ( | |||
| memoryPer100TiB = sectorsPer100TiB * 32 | |||
| ) | |||
|
|
|||
| var ( | |||
| ErrBalanceInsufficient = errors.New("ephemeral account balance was insufficient") | |||
| ErrMaxBalanceExceeded = errors.New("ephemeral account maximum balance exceeded") | |||
There was a problem hiding this comment.
Not sure we still need this one. Theoretically with the simplified pricing, we should hopefully not have to worry about that.
ChrisSchinnerl
force-pushed
the
chris/rhp4-errors
branch
from
c7d204c
to
a5331c5
Compare
|
Closing this since it probably belongs into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The renter and host need to agree on errors to return for individual RPCs. This PR adds the expected behavior to the corresponding interface methods.
Right now hostd returns an internal error when an account doesn't exist. That's suboptimal since renterd can't take action based on that. Returning an error for missing accounts seems a bit redundant so I propose just returning a balance of 0 similar to how we do in rhp3.