Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard messages sent after the close message has been posted to the queue #79

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Discard messages sent after the close message has been posted to the queue #79

merged 1 commit into from
Oct 27, 2024

Conversation

Shane32
Copy link
Owner

@Shane32 Shane32 commented Oct 27, 2024

No behavioral change, as HandleOutgoingMessageAsync already does this, just after the message has been dequeued.

@Shane32 Shane32 self-assigned this Oct 27, 2024
@github-actions GitHub Actions
Copy link

Coverage Report

Totals Coverage
Statements: 96.95% ( 1878 / 1937 )
Methods: 81.3% ( 287 / 353 )

@Shane32 Shane32 merged commit 39f8dd8 into master Oct 27, 2024
5 checks passed
@Shane32 Shane32 deleted the discard_after_close branch October 27, 2024 13:52
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11541007857

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 94.534%
Totals Coverage Status
Change from base Build 11540995157: 0.006%
Covered Lines: 1878
Relevant Lines: 1937
💛 - Coveralls

@Shane32 Shane32 added this to the 6.1.0 milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Shane32 Shane32

Labels
None yet
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Shane32 @coveralls