Reflect ping payload in pong (#77)

Shane32 · Oct 27, 2024 · cbd7a33 · cbd7a33
1 parent 5ee3f0a
commit cbd7a33
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/GraphQL.AspNetCore3/WebSockets/GraphQLWs/SubscriptionServer.cs b/src/GraphQL.AspNetCore3/WebSockets/GraphQLWs/SubscriptionServer.cs
@@ -115,7 +115,9 @@ public override async Task OnMessageReceivedAsync(OperationMessage message)
     /// Executes when a ping message is received.
     /// </summary>
     protected virtual Task OnPingAsync(OperationMessage message)
-        => Connection.SendMessageAsync(_pongMessage);
+        => message.Payload == null
+        ? Connection.SendMessageAsync(_pongMessage)
+        : Connection.SendMessageAsync(new OperationMessage { Type = MessageType.Pong, Payload = message.Payload });
 
     /// <summary>
     /// Executes when a pong message is received.

diff --git a/src/Tests/WebSockets/NewSubscriptionServerTests.cs b/src/Tests/WebSockets/NewSubscriptionServerTests.cs
@@ -94,11 +94,15 @@ public async Task Message_ThrowsWhenNotInitialized(string? messageType)
     }
 
     [Theory]
-    [InlineData(false)]
-    [InlineData(true)]
-    public async Task Message_Ping(bool initialized)
+    [InlineData(false, false)]
+    [InlineData(false, true)]
+    [InlineData(true, false)]
+    [InlineData(true, true)]
+    public async Task Message_Ping(bool initialized, bool withPayload)
     {
         var message = new OperationMessage { Type = "ping" };
+        if (withPayload)
+            message.Payload = new { id = Guid.NewGuid().ToString("N") };
         _mockServer.Protected().Setup<Task>("OnPingAsync", message)
             .Returns(Task.CompletedTask).Verifiable();
         if (initialized) {