Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not call scoop externally from inside the code #5695

Merged

Conversation

hagaigold
Copy link
Contributor

@hagaigold hagaigold commented Oct 14, 2023

Description

Call scoop internally instead of calling it externally from inside the code.

Motivation and Context

Overall, calling "myself" externally, it is bad practice, unless there is a good reason for doing it.

Closes #5694

How Has This Been Tested?

> scoop create
Usage: scoop create <url>

Create your own custom app manifest

> scoop install make
WARN  Skipping self-update of Scoop Core until 12/31/2023 00:00:00...
WARN  If you want to update Scoop Core immediately, use 'scoop unhold scoop; scoop update'.
Updating Buckets...
Scoop was updated successfully!
Installing 'make' (4.4.1) [64bit] from main bucket
Loading make-4.4.1-without-guile-w32-bin.zip from cache
Checking hash of make-4.4.1-without-guile-w32-bin.zip ... ok.
Extracting make-4.4.1-without-guile-w32-bin.zip ... done.
Linking C:\codew\scoop\apps\make\current => C:\codew\scoop\apps\make\4.4.1
Creating shim for 'make'.
'make' (4.4.1) was installed successfully!

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@rashil2000 rashil2000 merged commit 7b35e19 into ScoopInstaller:develop Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants