Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Disaster Recovery for AWS #105

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

PiyushRaj927
Copy link
Collaborator

@PiyushRaj927 PiyushRaj927 commented Aug 31, 2023

Related PR #22
This PR adds

  • Dockerfile for the Barman image.
  • Addition of Terraform and Ansible scripts for setting up Postgres with barman configuration.
  • Modification of the Dockerfile to incorporate SSH capabilities.
  • Updates to the README.md reflecting the latest modifications.

DEMO LINK: https://drive.google.com/file/d/1PCPS44IseqJcQxAZVZjvAb-fTF6RiVrB/view?usp=sharing

@singhalkarun
Copy link
Collaborator

Hi @PiyushRaj927 I see ssh access has been added to the main Dockerfile. Since, it is something experimental in nature, can we have a separate Dockerfile with ssh access and keep the main WarpSQL image as it is. Once we have a solution on how to utilize SSH of the VM itself, we will anyways have to remove the ssh part from the Dockerfile.

You can create a folder in a similar manner how you've created for barman.

@PiyushRaj927
Copy link
Collaborator Author

Hi @singhalkarun I've made the recommended changes. Please take a look and review them.

@singhalkarun
Copy link
Collaborator

Hi @PiyushRaj927 Functionally the code looks good. Merging it. Although feel there can be code cleaning that can be done which you can pick up.

e.g., you can use dynamic inventory to fetch addresses of machine while running ansible file instead of creating an inventory file during launching instances.

@singhalkarun singhalkarun merged commit ad8ae79 into Samagra-Development:main Sep 4, 2023
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants