-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foreground transfer function #30
Draft
arahlin
wants to merge
63
commits into
main
Choose a base branch
from
separate_Fl_dust
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_model and dSdqb and make option for transfer function: 1/ from cmb signal, 2/ seperately from dust and cmb signal, 3/from (alpha*dust+cmb) signal
… for reading spectra from disk
* use separate seeds for each sim and component * clean up code to not rebuild existing files
* consistent foreground_type and foreground_type_transfer options for handling foreground components in covariance model and transfer function calculation * fix_fg_transfer option fixes transfer function to be the same as CMB, interpolated onto the foreground binning * beta_fit option enables or disables fitting for delta_beta in addition to foreground amplitudes * correct calculation of window functions for foreground bins
… separate_Fl_dust
cleanup to simplify later merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forergound spectra have a correlation structure in ell space that is distinct from the CMB. This means that the XFaster-computed binned transfer function may differ between these two types of signal components.
This PR introduces
foreground_type
andforeground_transfer_type
options that behave analogously tosignal_type
andsignal_transfer_type
, so that the foreground transfer function is computed from a separate ensemble of sims. In principle, this should improve the accuracy of the bandpower calculation with a harmonic-domain foreground component.However, there seems to be something fundamentally broken in the foreground code, such that the final covariance contains negative eigenvalues. This failure may not be specific to this branch.