Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript configuration for Fiori elements apps #1286

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Conversation

c-kobo
Copy link
Member

@c-kobo c-kobo commented Nov 20, 2024

This PR enables typescript for both apps Travel Processor and Travel Analytics.
Additionally, for the Travel Processor App, the following flexible programming model based extensions are added:

  • a custom section combining a message strip and a table building block. This replaces the standard booking table section
  • a controller extension: when saving, it is checked whether trees-4-tickets checkbox has been selected, a dialog is shown giving the user the option to do so before save continues.

@c-kobo c-kobo changed the title Typescript configuration and for Fiori elements apps Typescript configuration for Fiori elements apps Nov 20, 2024
Copy link

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c-kobo A few small comments to align with fiori tools generation of new projects.
I noticed a test failing here.
http://localhost:4004/sap.fe.cap.travel/test/integration/Opa.qunit.html

app/travel_analytics/package.json Show resolved Hide resolved
app/travel_analytics/package.json Show resolved Hide resolved
app/travel_analytics/ui5.yaml Show resolved Hide resolved
app/travel_processor/package.json Show resolved Hide resolved
app/travel_processor/package.json Show resolved Hide resolved
app/travel_processor/ui5.yaml Show resolved Hide resolved
@c-kobo
Copy link
Member Author

c-kobo commented Nov 27, 2024

Wrt to the failing OPA tests, my colleague @ARiesterer will try to take a look into it.

@c-kobo
Copy link
Member Author

c-kobo commented Nov 27, 2024

Wrt to the failing OPA tests, my colleague @ARiesterer will try to take a look into it.

OPA tests should be fine again now.

@c-kobo
Copy link
Member Author

c-kobo commented Nov 27, 2024

Jest tests still failing.

@c-kobo
Copy link
Member Author

c-kobo commented Nov 28, 2024

@stewsk @chgeo the jest tests fail due to an incompability with cds-plugin-ui5.
Seems to be an issue with jest and node in combination with plugins.
@petermuessig described a workaround here (requires upgrade to node21):
ui5-community/ui5-ecosystem-showcase#901 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants