Ensure the correct error message is shown when failing to open a Uri in paywalls #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion if no browser is installed.
📸 Snapshot Test74 unchanged
🛸 Powered by Emerge Tools |
vegaro
approved these changes
Nov 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1922 +/- ##
=======================================
Coverage 82.17% 82.17%
=======================================
Files 232 232
Lines 8101 8101
Branches 1146 1146
=======================================
Hits 6657 6657
Misses 991 991
Partials 453 453 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
@vegaro I requested re-review as my last commit changed some stuff around again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick follow-up to #1904.
Motivation
We have 2 error cases when opening Uris:
However, if the app includes a more recent version of Compose,
UriHandlerthrows the same exception (IllegalArgumentException) for both of these cases (source), which means we never actually show the "No browser installed" error message.This PR fixes that by no longer relying on
UriHandler, and implementing the (very simple) logic ourselves. I think this is justified, as we cannot know which version ofUriHandlerwe get at runtime.