Hack to get around Rails 4 and Devise 3.0.0.rc issue #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dont know if you are looking for feedback on Rails 4, but upgrading to Devise 3.0.0.rc breaks the registration process. It has to do with how Devise changed the build_resource method to support strong parameters. This line no longer returns the visitors email address.
https://github.com/RailsApps/rails-prelaunch-signup/blob/master/app/controllers/registrations_controller.rb#L5
The change in Devise here https://github.com/plataformatec/devise/blob/master/app/controllers/devise/registrations_controller.rb#L85 is the culprit.
I made a hack to get around it and it may not be best way to fix it, but I thought I'd share it anyway.