Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DM/FEATURE] Update Pin core #9604

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[DM/FEATURE] Update Pin core #9604

wants to merge 5 commits into from

Conversation

GuEe-GUI
Copy link
Contributor

@GuEe-GUI GuEe-GUI commented Nov 1, 2024 •
edited
Loading

[

  1. Fixup pin depend auto.
  2. Fixup pin flags get from OFW.
  3. Support virtual pin for multi gpio chip.
  4. Add sets pin debounce time API.

Depends on: #9576

  • BSP:
    qemu-virt64-aarch64
    rockchip/rk3568

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@GuEe-GUI
[DM/FIXUP] Fixup pin depend auto
ab0ca30 
Signed-off-by: GuEe-GUI <[email protected]>
@GuEe-GUI
[DM/FIXUP] Fixup pin flags get from OFW
4f86d07 
Only check HIGH or LOW

Signed-off-by: GuEe-GUI <[email protected]>
@GuEe-GUI GuEe-GUI marked this pull request as draft November 1, 2024 05:34
@GuEe-GUI GuEe-GUI marked this pull request as ready for review November 20, 2024 05:27
@GuEe-GUI
[DM/FEATURE] Support virtual pin
18b2271 
1. There is only one GPIO device in System.
2. For Pin API input is pin number
3. Add sets pin debounce time API.

So we need a virtual pin for multi gpio chip.

Signed-off-by: GuEe-GUI <[email protected]>
@GuEe-GUI
[DM/FEATURE] Support import SoC PIN config
a5c443b 
Signed-off-by: GuEe-GUI <[email protected]>
@GuEe-GUI
Copy link
Contributor Author

@Rbb666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: drivers Component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GuEe-GUI