Fix stream-k kernels when K==0, allow beta*C calculation #1399
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexBrownAMD
requested review from
neoblizz,
bethune-bryant,
mahmoodw and
daineAMD
AlexBrownAMD
requested review from
jichangjichang,
KKyang,
aazz44ss,
vin-huang,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh and
solaslin
as code owners
ellosel
reviewed
Dec 3, 2024
Comment on lines
+3034
to
+3038
| size_t z = 1; | ||
| for(size_t i = 0; i < problem.boundIndices().size(); ++i) | ||
| { | ||
| z *= problem.boundSize(i); | ||
| } |
There was a problem hiding this comment.
There is probably a way to do this in one line using std::reduce assuming there is a way to iterate over whatever boundSize refers to.
KKyang
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug causing problems with K=0 to end early. With this change if K==0 only main loop is skipped, and beta*C will be calculated.