Add extended profile logging along with flush and rotating size #1389
+309
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NaveenElumalaiAMD
commented
Nov 25, 2024
NaveenElumalaiAMD
commented
- Added Extended profile logging which prints out extra information: Solution Index, Solution name and Kernel name.
- Add flush and rotating size to bench, profile and Extended profile logging.
NaveenElumalaiAMD
requested review from
jichangjichang,
KKyang,
aazz44ss,
vin-huang,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh and
solaslin
as code owners
TorreZuk
reviewed
Nov 25, 2024
|
Customer is complaining about the log format changes frequently, if there's any other changes, please submit them in this PR. |
smalekta
reviewed
Nov 27, 2024
| ->as<hipblaslt_ext::SoftmaxSolutionLibrary>(); | ||
| auto sol | ||
| = lib.findBestSolution(hipblaslt_ext::SoftmaxProblem(m, n, hipDataType_to_tensile_type(datatype)), *gpu); | ||
| const auto& lib = masterLib |
There was a problem hiding this comment.
NBD, but these are just reformatting? makes PR review harder
There was a problem hiding this comment.
Yes these are formatting changes. Maybe standardizing the clang-format could make it easy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.