[UI v2] Variables table - part 2 #16025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
added
the
development
desertaxle
requested review from
aaazzam,
cicdw and
zzstoatzz
as code owners
aaazzam
approved these changes
Nov 15, 2024
Comment on lines
+154
to
+160
| <div> | ||
| <div className="grid sm:grid-cols-2 md:grid-cols-6 lg:grid-cols-12 gap-2 pb-4 items-center"> | ||
| <div className="sm:col-span-2 md:col-span-6 lg:col-span-4 order-last lg:order-first"> | ||
| <p className="text-sm text-muted-foreground"> | ||
| {currentVariableCount} Variables | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
I see the CREATE action is in the parent component, but the filtering fields are colocated with the table itself. This is totally fine, but how are you thinking about that in general?
There was a problem hiding this comment.
The filters feel more related to the table than the parent component since I can't imagine a scenario where you'd want the table without the filters, but I'm open to changing this layout as we build more.
| }) => { | ||
| columnFilters, | ||
| onColumnFiltersChange, | ||
| searchDebounceMs = 500, |
There was a problem hiding this comment.
let's keep this south of ~200-250ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes up the variables table by adding filtering, page size selection, and sorting to the table. This PR also refactors the
TagsInputcomponent slightly to fit into the table filtering layout a little better.Here are some of the changes in action:
Related to #15512