Add sidebar to v2 UI #15925
Merged
Add sidebar to v2 UI #15925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaazzam
requested changes
Nov 4, 2024
aaazzam
reviewed
Nov 4, 2024
|
|
||
| const items = [ | ||
| { | ||
| title: "Dashboard", |
There was a problem hiding this comment.
over optimization, but if instead of 'title', 'url' we do
{'children': whatever, 'linkProps': { to: '/' }}
then it can easier to reason about and include non text item for children. Also, if we type linkProps correctly we can use typesafety to make sure this nav items list handshakes right. happy to do this in a future PR this isn't blocking
There was a problem hiding this comment.
I implemented a new way to define these items in dae469e. It's a bit different than what you suggested, but I think it gives the flexibility that we need.
aaazzam
approved these changes
Nov 11, 2024
| import { Link } from "@tanstack/react-router"; | ||
| import { Button } from "@/components/ui/button"; | ||
|
|
||
| const navItems = [ |
There was a problem hiding this comment.
at this point would recommend just having a million sidebar items than this config object
zzstoatzz
approved these changes
Nov 11, 2024
desertaxle
added
the
development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a sidebar to the v2 UI. It looks like this:
The sidebar was created entirely with components from
shadcn/ui.All the tabs correspond to real routes, but most will take the user to a placeholder page.
This PR also introduces
huskyfor pre-commit checks/formatting andvitestandmswfor tests.mswseems to work well for mocking out API calls in tests.Related to #15512