Fix block reference load in async flow #15487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalLadislav
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
CodSpeed Performance ReportMerging #15487 will not alter performanceComparing Summary
|
desertaxle
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Thanks for the fix @GalLadislav! I think we'll want to revisit this when working on #15008 to create sync and async versions of validate_parameters, but this makes sense to me for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes loading block references in async flows. For async flows it throws
ParameterTypeErroras the sync compatibleBlock.load_from_refcall does not runs the coroutine.Related to no existing issue (or i could not find any) and i assumed that it might not need one.
Checklist