Enhancement: Disable Deployments

[dylanbhughes]

Closes #14529

Checklist

• This pull request references any related issue by including "closes <link to issue>"
  • If no issue exists and your change is not a small fix, please create an issue first.
• If this pull request adds new functionality, it includes unit tests that cover the changes
• If this pull request removes docs files, it includes redirect settings in mint.json.
• If this pull request adds functions or classes, it includes helpful docstrings.

[codspeed-hq]

CodSpeed Performance Report

Merging #15129 will not alter performance

_{Comparing enhancement/#14529/disabled-deployments (1b405b1) with main (6dd34dc)}

Summary

✅ 3 untouched benchmarks

[znicholasbrown]

UI side of this looks good, just a minor nit

[aaazzam]

Hey @dylanbhughes!

Excited to get this toggle back on the deployment list view. There's a pretty gnarly bug / regression in #14973 which will have some non-breaking but otherwise nontrivial implications for how schedules are created. For the 3.0 branch, I consider work on that issue as blocking on getting this merged 😞, so hang tight. The exact spelling of the bugfix isn't settled yet, but it may require changes to the backend design here (double 😞). No action needed on your part, but we should pause on this for now.

[github-actions]

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

[dylanbhughes]

comment

[dylanbhughes]

comment

[github-actions]

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

[dylanbhughes]

comment

[dylanbhughes]

Hey Team 👋 wanted to resurface this PR. I'm not 100% sure that this issue is really blocking. It doesn't seem like we intend to change the schedule reactivation behavior when a flow is deployed.

Since we're seeing some user interest in the feature, I wanted to see if we could reignite discussion on the disabling deployments feature and see if there's a path to getting this merged.

cc @aaazzam @zzstoatzz @cicdw @desertaxle

[desertaxle]

@dylanbhughes I think the issue that @aaazzam called out is tangentially related since changing the disabled/enabled state of a deployment via any of our SDK methods could change the schedule state unexpectedly. That's an issue with the SDK and not this work, so I think we could find a way to implement this without first resolving that issue.

Here's a potential way to add this feature while steering clear of our current footguns: this feature starts as an API/UI feature only. This will allow users to disable deployments from the UI where it's most likely to be used, and we can add this feature to the SDK once we've improved our deployment update story.

Happy to hear pushback or other ideas!

[dylanbhughes]

I think that sounds great! Disabling or enabling a deployment feels like it should be a pretty explicit action and probably shouldn't occur as a side effect of another action anyway. I'll clean this PR up and do some testing -- hoping to have something by EOW/early next week.

[github-actions]

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

[dylanbhughes]

comment

[github-actions]

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

[dylanbhughes]

Comment