Fixes #1 #11
Open
Fixes #1 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mad-alpha for this Fix, I will review it soon. |
|
This should not be done on the server side but on client side. You have to send a timestamp here, which will be sent to other user: Also you will have to render it in the UI. |
PradyumnaKrishna
added
gssoc23
|
Any help required @mad-alpha? I can assist you if you wanted. |
JigarJoshi04
suggested changes
May 28, 2023
| @@ -49,6 +50,7 @@ type Message struct { | |||
| User string `json:"user"` | |||
| Text string `json:"message,omitempty"` | |||
| To string `json:"to,omitempty"` | |||
| Timstamp string `json:"timestamp,omitempty"` | |||
There was a problem hiding this comment.
More suitable datatype is *time.Time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timestamp with every message on client side as well as in user cards.