Misc small fixes and improvements #6179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvieth
force-pushed
the
misc14
branch
2 times, most recently
from
9a6b4eb
to
bae92d1
Compare
larshg
reviewed
Nov 28, 2024
sample_consensus/include/pcl/sample_consensus/impl/sac_model_ellipse3d.hpp
Show resolved
Hide resolved
larshg
reviewed
Nov 28, 2024
sample_consensus/include/pcl/sample_consensus/impl/sac_model_ellipse3d.hpp
Outdated
Show resolved
Hide resolved
- remove unused variables in dominant_plane_segmentation.hpp, integral_image_normal.hpp, our_cvfh.hpp - remove unnecessary parenthesis in pcl_macros.h (otherwise the deprecation messages are "It will be removed in PCL (1).15") - ply_io.cpp: catch exception when parsing bad ply files - add includes for KdTree, OrganizedNeighbor, eigen33 (the files use these classes/functions, so the headers should be included; currently they rely on transitive includes) - in random_sample.h: use srand_deterministic on OpenBSD to properly use seed and fix failing test on OpenBSD - in pcl_visualizer.cpp: replace 5 with better value. The Boost doc only says that digest_type is at least 16 bytes large (in the current code it is 20 bytes large). Additionally, there is no guarantee that unsigned int is 4 bytes large (even if that is the most common situation)
larshg
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commit messages for details.
Related: #6178
Fixes #6162