Automates uninstallation method #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PixlOne
force-pushed
the
main
branch
14 times, most recently
from
a062ed0
to
a77b328
Compare
Flimm
suggested changes
May 20, 2024
| } | ||
|
|
||
| get_manifest_path() { | ||
| local manifest_path=$(find . -name 'install-manifest.txt' -type f -print) |
There was a problem hiding this comment.
The file is named install_manifest.txt , not install-manifest.txt , at least when I tried it.
|
|
||
| get_manifest_path() { | ||
| local manifest_path=$(find . -name 'install-manifest.txt' -type f -print) | ||
| if [ 1 -lt ${#manifest_path} ]; then |
There was a problem hiding this comment.
I'm not sure what this line is meant to do. Is it checking for an empty string? It doesn't seem to work as intended for me.
| get_manifest_path() { | ||
| local manifest_path=$(find . -name 'install-manifest.txt' -type f -print) | ||
| if [ 1 -lt ${#manifest_path} ]; then | ||
| printf '%s\n' "This repo has not been built yet. Please build it to generate install-manifest.txt. Continuing..." |
There was a problem hiding this comment.
It would be good if this error got printed to stderr, to avoid corrupting the result of $(get_manifest_path)
| echo "manifest_path is $manifest_path" | ||
| while IFS= read -r line; do | ||
| printf '%s\n' "Removing $line.." | ||
| rm "$line" |
There was a problem hiding this comment.
This line needs to be preceded with sudo to avoid a "permission denied" error. Or the whole script needs to be run with sudo .
It also may need a -f to stop an error code from causing this function to exit early, since set -e has been set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In response to #83 regarding uninstallation difficulties, this PR introduces a bash script to automate uninstall of the logiops driver and disable it in systemd.
Testing Instructions
systemctl status logid../uninstall.sh.