Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove db.site.lat.lon function and replace all usages with query.site #3308

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

Sweetdevil144
Copy link
Contributor

@Sweetdevil144 Sweetdevil144 commented Jun 19, 2024

Description

  • query.site retrieves lat and lon.

  • Removed unused db.site.lat.lon function

A small part of #3307

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

… retrieve the lat and lon

Signed-off-by: Abhinav Pandey <[email protected]>
Signed-off-by: Abhinav Pandey <[email protected]>
Copy link
Member

@infotroph infotroph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great. Can you please also add an entry to the NEWS.md of data.atmosphere saying that db.site.lat.lon was removed and users should use PEcAn.DB::query.site(id, con)[c("lat", "lon")] instead? Make sure to credit yourself and this PR number.

Signed-off-by: Abhinav Pandey <[email protected]>
@infotroph infotroph added this pull request to the merge queue Jun 21, 2024
Merged via the queue into PecanProject:develop with commit c027ba2 Jun 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants