-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) UHM-8240 Create O2 Visit Summary workspace for Ward App #1
Conversation
@@ -0,0 +1,4 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why, but I had to manually add these translations in, even though there is an extract-translations
pre-commit hook. Projects like openmrs-esm-patient-management
automatically updates this file on commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to see if we can get an answer to why that is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, thanks @chibongho!
I will add some notes about how to test the referrals queue.
@@ -0,0 +1,57 @@ | |||
{ | |||
"name": "@pih/esm-commons-app", | |||
"version": "2.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, but wouldn't we start with 1.0.0?
}, []); | ||
|
||
if (patient && visit) { | ||
const src = `/openmrs/pihcore/visit/visit.page?patient=${patient.uuid}&visit=${visit.uuid}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but, annoyingly, in Mirebalais the web app is called "mirebalais", not "openmrs". I think we have a variable with the webapp name? Otherwise, we can cross this bridge when we come to it (we've wanted to rename the Mirebalais web app for years).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find a variable for it. I'll leave it as is for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure there must be a variable for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found openmrsBase
. I just pushed a change to make it use that.
@chibongho the referrals queue can be tested on HUM-CI (I'm fine if you want to merge and test after merging). It's the "J9 Referrals" app availalbe at the Sante Famn location: If you set the date back a few months, some referrals should show up: |
Summary
Adds a new workspace (extensions) for the ward app to open up the O2 Visit Summary page for a patient. The workspace is created under a new app called
esm-commons-app
.Tested this locally by doing
yarn start --sources packages/esm-commons-app/ --port 8081 --backend http://localhost:8080 --config-file ../sl_local_config.json
. We'll also need thespa-build-config.json
file inopenmrs-frontend-pihemr
to include the new app.I also upgraded
openmrs-esm-core
, and a few things (liketurbo
) to match versions used byopenmrs-esm-patient-management
. I had to change a few things inesm-referrals-app
as a result. They seem benign, but I haven't tested them. (Let me know what to test for.)Screenshots
Note that there are both the "regular" O3 Visit Summary and the O2 Visit Summary in the action menu of the workspace. I'll make a corresponding config change to hide / reorder the appropriate icons.
Related Issue
https://pihemr.atlassian.net/browse/UHM-8240