Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typehints for ALPHA7 #83

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Typehints for ALPHA7 #83

wants to merge 5 commits into from

Conversation

xXSirGamesXx
Copy link

Introduction

Relevant issues

Fixes #80

Changes (ABC)

API changes

Allows for 3.0.0-ALPHA7

Behavioural changes

Configuration changes

Backwards compatibility

None

Follow-up

Sorry about the last pr, was really messy

Tests

SOF3
SOF3 requested changes Aug 24, 2017
View reviewed changes
src/HereAuth/Command/HereAuthCommand.php Outdated
@@ -49,11 +49,11 @@ public function getMessage(string $key, string $default) : string{
/**
* @return HereAuth
*/
public function getPlugin(){
public function getPlugin() : \pocketmine\plugin\Plugin {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why FQN?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it

SOF3
SOF3 requested changes Aug 25, 2017
View reviewed changes
Copy link
Collaborator

@SOF3 SOF3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't update the declared API version.

@xXSirGamesXx
Copy link
Author

Done

@SOF3
Copy link
Collaborator

SOF3 commented Aug 28, 2017

ALPHA8 is coming soon though. I'll wait for it before updating.

@LewBr
Copy link

LewBr commented Sep 14, 2017

What should i do whit this error in ALPHA7?

14.09 11:50:18 [Server] Server thread/CRITICAL Could not pass event 'pocketmine\event\server\DataPacketSendEvent' to 'LeoHarduA v4.0.0': Return value of pocketmine\entity\Entity::getId() must be of the type integer, null returned on HereAuth\EventRouter
14.09 11:50:18 [Server] Server thread/CRITICAL TypeError: "Return value of pocketmine\entity\Entity::getId() must be of the type integer, null returned" (EXCEPTION) in "src/pocketmine/entity/Entity" at line 1854
14.09 11:50:18 [Server] Server thread/DEBUG #0 LeoHarduA/src/HereAuth/HereAuth(250): pocketmine\entity\Entity->getId()
14.09 11:50:18 [Server] Server thread/DEBUG #1 LeoHarduA/src/HereAuth/EventRouter(257): HereAuth\HereAuth->getUserByPlayer(pocketmine\Player object)
14.09 11:50:18 [Server] Server thread/DEBUG #2 src/pocketmine/plugin/MethodEventExecutor(38): HereAuth\EventRouter->onSend(pocketmine\event\server\DataPacketSendEvent object)
14.09 11:50:18 [Server] Server thread/DEBUG #3 src/pocketmine/plugin/RegisteredListener(98): pocketmine\plugin\MethodEventExecutor->execute(HereAuth\EventRouter object, pocketmine\event\server\DataPacketSendEvent object)
14.09 11:50:18 [Server] Server thread/DEBUG #4 src/pocketmine/plugin/PluginManager(714): pocketmine\plugin\RegisteredListener->callEvent(pocketmine\event\server\DataPacketSendEvent object)
14.09 11:50:18 [Server] Server thread/DEBUG #5 src/pocketmine/Player(1104): pocketmine\plugin\PluginManager->callEvent(pocketmine\event\server\DataPacketSendEvent object)
14.09 11:50:18 [Server] Server thread/DEBUG #6 src/pocketmine/Player(1072): pocketmine\Player->sendDataPacket(pocketmine\network\mcpe\protocol\PlayStatusPacket object, boolean , boolean )
14.09 11:50:18 [Server] Server thread/DEBUG #7 src/pocketmine/Player(1999): pocketmine\Player->dataPacket(pocketmine\network\mcpe\protocol\PlayStatusPacket object)
14.09 11:50:18 [Server] Server thread/DEBUG #8 src/pocketmine/Player(1845): pocketmine\Player->sendPlayStatus(integer 0)
14.09 11:50:18 [Server] Server thread/DEBUG #9 src/pocketmine/Player(1988): pocketmine\Player->processLogin()
14.09 11:50:18 [Server] Server thread/DEBUG #10 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(102): pocketmine\Player->handleLogin(pocketmine\network\mcpe\protocol\LoginPacket object)
14.09 11:50:18 [Server] Server thread/DEBUG #11 src/pocketmine/network/mcpe/protocol/LoginPacket(109): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleLogin(pocketmine\network\mcpe\protocol\LoginPacket object)
14.09 11:50:18 [Server] Server thread/DEBUG #12 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(94): pocketmine\network\mcpe\protocol\LoginPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
14.09 11:50:18 [Server] Server thread/DEBUG #13 src/pocketmine/network/mcpe/protocol/BatchPacket(106): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\LoginPacket object)
14.09 11:50:18 [Server] Server thread/DEBUG #14 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(94): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
14.09 11:50:18 [Server] Server thread/DEBUG #15 src/pocketmine/Player(3072): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
14.09 11:50:18 [Server] Server thread/DEBUG #16 src/pocketmine/network/mcpe/RakLibInterface(145): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
14.09 11:50:18 [Server] Server thread/DEBUG #17 src/raklib/server/ServerHandler(97): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string 201.92.75.130:65138, raklib\protocol\EncapsulatedPacket object, integer 0)
14.09 11:50:18 [Server] Server thread/DEBUG #18 src/pocketmine/network/mcpe/RakLibInterface(84): raklib\server\ServerHandler->handlePacket()
14.09 11:50:18 [Server] Server thread/DEBUG #19 src/pocketmine/network/Network(89): pocketmine\network\mcpe\RakLibInterface->process()
14.09 11:50:18 [Server] Server thread/DEBUG #20 src/pocketmine/Server(2473): pocketmine\network\Network->processInterfaces()
14.09 11:50:18 [Server] Server thread/DEBUG #21 src/pocketmine/Server(2239): pocketmine\Server->tick()
14.09 11:50:18 [Server] Server thread/DEBUG #22 src/pocketmine/Server(2118): pocketmine\Server->tickProcessor()
14.09 11:50:18 [Server] Server thread/DEBUG #23 src/pocketmine/Server(1700): pocketmine\Server->start()
14.09 11:50:18 [Server] Server thread/DEBUG #24 src/pocketmine/PocketMine(541): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string phar:///custom7.phar/, string /, string /plugins/)
14.09 11:50:18 [Server] Server thread/DEBUG #25 /custom7.phar(1): require(string phar:///custom7.phar/src/pocketmine/PocketMine.php)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SOF3 SOF3 SOF3 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xXSirGamesXx @SOF3 @LewBr