Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Footer #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Ferdinand-Ogama
Copy link

Check and let me know if you need any changes.

@vercel
Copy link

vercel bot commented Oct 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
acm-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2023 11:16pm

@Ishwarendra
Copy link
Contributor

Ishwarendra commented Oct 23, 2023

This is not ok. Also don't use margin padding to fix this thing. @Ferdinand-Ogama

image

@Ferdinand-Ogama
Copy link
Author

Where is the problem?

At the time I was requesting the PR, mine looked like this.

Untitled

@ken1000minus7
Copy link
Contributor

I would say avoid giving it an absolute position and fixing it at the bottom of the screen, what say @Ishwarendra

@Ishwarendra
Copy link
Contributor

I would say avoid giving it an absolute position and fixing it at the bottom of the screen, what say @Ishwarendra

Sounds good. Let's keep it this way

@Ishwarendra
Copy link
Contributor

Where is the problem?

At the time I was requesting the PR, mine looked like this.

Untitled

This is because you are at a page with no content. If the content exceeds the size of screen then you will be able to see the issue. Also there seems to be conflict in package-lock.json fix that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants