Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MediaWiki >= 1.35 #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jdlrobson
Copy link

I would like to showcase this skin on https://skins.wmflabs.org/ and update the skins status on https://www.mediawiki.org/wiki/Skin:Overclocked to stable.

The skin requires extension registration via wfLoadSkin in
1.35 and the method setupSkinUserCss is deprecated.

This change should have no effect on older versions of MediaWiki.

The skin requires extension registration via wfLoadSkin in
1.35 and the method setupSkinUserCss is deprecated.

This change should have no effect on older versions of MediaWiki.
@jdlrobson
Copy link
Author

@PCGamingWiki is this still still maintained? Would love to see it marked as stable again on https://www.mediawiki.org/wiki/Skin:Overclocked

@Dave247
Copy link
Contributor

Dave247 commented Apr 18, 2022

I was doing some of my old testing on some test environments I created. The current skin won't even load on MW 1.37 and there's a number of PHP deprecation messages in the Apache error log. Using your fork though the messages are still there but the site loads so already there's a big improvement.

I've been told though 1.35 is being targeted for the eventual upgrade where the skin seems to already work, though I am unsure but don't believe it had undergone any changes there.
https://staging.pcgamingwiki.com/wiki/Special:Version

@jdlrobson
Copy link
Author

Using your fork though the messages are still there but the site loads so already there's a big improvement.
Yep that's because I've only patched 1.35 and 1.36, not 1.37. If this pull request is merged and the skin is maintained I will submit patches for the later 1.37 branches.

@jdlrobson
Copy link
Author

Any updates on the PC gaming wiki update? Let me know if you need support for 1.36 and I can provide a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants