Merge pull request #886 from OxygenCobalt/hotfixes

v3.6.1

CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 3.6.1
+
+#### What's Fixed
+- Fixed possible crash from poor service initalization
+- Fixed issue where it was impossible to edit playlists
+- Fixed issue where playlist would revert to older version when re-edited
+
+#### Dev/Meta
+- Fixed service memory leaks
+
 ## 3.6.0
 
 #### What's New

README.md

@@ -2,8 +2,8 @@
 <h1 align="center"><b>Auxio</b></h1>
 <h4 align="center">A simple, rational music player for android.</h4>
 <p align="center">
-    <a href="https://github.com/oxygencobalt/Auxio/releases/tag/v3.6.0">
-        <img alt="Latest Version" src="https://img.shields.io/static/v1?label=tag&message=v3.6.0&color=64B5F6&style=flat">
+    <a href="https://github.com/oxygencobalt/Auxio/releases/tag/v3.6.1">
+        <img alt="Latest Version" src="https://img.shields.io/static/v1?label=tag&message=v3.6.1&color=64B5F6&style=flat">
     </a>
     <a href="https://github.com/oxygencobalt/Auxio/releases/">
         <img alt="Releases" src="https://img.shields.io/github/downloads/OxygenCobalt/Auxio/total.svg?color=4B95DE&style=flat">

app/build.gradle

@@ -21,8 +21,8 @@ android {
 
     defaultConfig {
         applicationId namespace
-        versionName "3.6.0"
-        versionCode 50
+        versionName "3.6.1"
+        versionCode 51
 
         minSdk 24
         targetSdk 34

app/src/main/java/org/oxycblt/auxio/AuxioService.kt

@@ -51,8 +51,8 @@ class AuxioService :
     override fun onCreate() {
         super.onCreate()
         playbackFragment = playbackFragmentFactory.create(this, this)
-        sessionToken = playbackFragment.attach()
         musicFragment = musicFragmentFactory.create(this, this, this)
+        sessionToken = playbackFragment.attach()
         musicFragment.attach()
     }
 

app/src/main/java/org/oxycblt/auxio/detail/DetailViewModel.kt

@@ -34,6 +34,7 @@ import org.oxycblt.auxio.detail.list.EditHeader
 import org.oxycblt.auxio.detail.list.SortHeader
 import org.oxycblt.auxio.list.BasicHeader
 import org.oxycblt.auxio.list.Divider
+import org.oxycblt.auxio.list.Header
 import org.oxycblt.auxio.list.Item
 import org.oxycblt.auxio.list.ListSettings
 import org.oxycblt.auxio.list.adapter.UpdateInstructions
@@ -430,6 +431,7 @@ constructor(
             // TODO: The user could probably press some kind of button if they were fast enough.
             //  Think of a better way to handle this state.
             _editedPlaylist.value = null
+            refreshPlaylist(playlist.uid)
         }
     }
 
@@ -522,12 +524,13 @@ constructor(
             }
     }
 
-    private fun <T : MusicParent> refreshDetail(
+    private inline fun <T : MusicParent> refreshDetail(
         detail: Detail<T>?,
         parent: MutableStateFlow<T?>,
         list: MutableStateFlow<List<Item>>,
         instructions: MutableEvent<UpdateInstructions>,
-        replace: Int?
+        replace: Int?,
+        songHeader: (Int) -> Header = { SortHeader(it) }
     ) {
         if (detail == null) {
             parent.value = null
@@ -540,7 +543,7 @@ constructor(
                 when (section) {
                     is DetailSection.PlainSection<*> -> {
                         val header =
-                            if (section is DetailSection.Songs) SortHeader(section.stringRes)
+                            if (section is DetailSection.Songs) songHeader(section.stringRes)
                             else BasicHeader(section.stringRes)
                         newList.add(Divider(header))
                         newList.add(header)
@@ -575,7 +578,9 @@ constructor(
         if (edited == null) {
             val playlist = detailGenerator.playlist(uid)
             refreshDetail(
-                playlist, _currentPlaylist, _playlistSongList, _playlistSongInstructions, null)
+                playlist, _currentPlaylist, _playlistSongList, _playlistSongInstructions, null) {
+                    EditHeader(it)
+                }
             return
         }
         val list = mutableListOf<Item>()

app/src/main/java/org/oxycblt/auxio/music/service/Indexer.kt

@@ -90,10 +90,10 @@ private constructor(
 
     fun release() {
         contentObserver.release()
-        musicSettings.registerListener(this)
-        musicRepository.addIndexingListener(this)
-        musicRepository.addUpdateListener(this)
+        musicRepository.unregisterWorker(this)
         musicRepository.removeIndexingListener(this)
+        musicRepository.removeUpdateListener(this)
+        musicSettings.unregisterListener(this)
     }
 
     override fun requestIndex(withCache: Boolean) {

app/src/main/java/org/oxycblt/auxio/playback/service/MediaSessionHolder.kt

@@ -113,9 +113,9 @@ private constructor(
      */
     fun release() {
         bitmapProvider.release()
+        playbackManager.removeListener(this)
         playbackSettings.unregisterListener(this)
         imageSettings.unregisterListener(this)
-        playbackManager.removeListener(this)
         mediaSession.apply {
             isActive = false
             release()

app/src/main/java/org/oxycblt/auxio/playback/service/PlaybackServiceFragment.kt

@@ -107,11 +107,11 @@ private constructor(
 
     fun release() {
         waitJob.cancel()
+        playbackManager.removeListener(this)
+        systemReceiver.release()
         widgetComponent.release()
-        context.unregisterReceiver(systemReceiver)
         sessionHolder.release()
         exoHolder.release()
-        playbackManager.removeListener(this)
     }
 
     override fun onSessionEnded() {

fastlane/metadata/android/en-US/changelogs/51.txt

@@ -0,0 +1,3 @@
+Auxio 3.6.0 improves support for android auto and fixes several small regressions.
+This release fixes critical issues identified in the previous version.
+For more information, see https://github.com/OxygenCobalt/Auxio/releases/tag/v3.6.0.