-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge latest development to master. #22
Open
0xsarvesh
wants to merge
30
commits into
master
Choose a base branch
from
develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repo: update readme narrative information and other details
Add SafeMath as npm dependency
Interacts using typechain
- Fixes lint erros. - Adds `npm run lint` as a check in .travis.yml - Runs `npm ci` instead of `npm i` - Slight improvements for package.json scripts section. Resolves: #14
- Aligns documentation mismatch of setAdmin() function with implementation. - Requires a new admin not to be the same as the current owner in setAdmin. Adds a negative unit test case. - Remove premature optimization that was checking a new admin address to be different than the current one before emitting event. Resolves: #3
Fixes lint-errors and integrates linting in Travis
Aligns setAdmin() docs with implementation.
Updated ganache-cli to 6.4.3
Removed safemath import from organization contracts
Update truffle dependency
updating versions for vulnerable NPM modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.