chore(cache): improve invalidation logic #45
Draft
+651
−215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sidux
commented
Jul 8, 2024
•
sidux
commented
- add more tests
- since tags now have the name of the property or the method added we need to check how to invalidate them all (drop redis database ?)
- check possible edge cases with imbricated requests
- add test to check key invalidation when manual tags change
sidux
force-pushed
the
improve-cache-invalidation
branch
2 times, most recently
from
1df0ed1
to
3dfa67f
Compare
sidux
force-pushed
the
improve-cache-invalidation
branch
from
3dfa67f
to
4d8df97
Compare
sidux
force-pushed
the
improve-cache-invalidation
branch
3 times, most recently
from
1f0a28c
to
b8729a3
Compare
|
Issued by Coverage Checker: |
sidux
commented
Jul 8, 2024
| private function normalizePrefixName(string $name): string | ||
| { | ||
| return str_replace( | ||
| ['\\', 'SharedResponse', 'Embedded', '_Shared'], |
sidux
commented
Jul 8, 2024
| if (!$member->isPublic() || \count($member->getParameters()) > 0) { | ||
| throw new \LogicException( | ||
| sprintf( | ||
| 'Method %s::%s must be public and have no parameters to be used as a tag.', |
sidux
commented
Jul 8, 2024
| if (!$member->isInitialized($object)) { | ||
| throw new \LogicException( | ||
| sprintf( | ||
| 'Property %s::%s must be initialized to be used as a tag.', |
sidux
commented
Jul 8, 2024
| if ($response !== null && \is_object($response)) { | ||
| $prefix = $this->normalizePrefixName(\get_class($response)); | ||
| } else { | ||
| $prefix = $this->normalizePrefixName( |
sidux
commented
Jul 8, 2024
| foreach ($ref->getProperties() as $propRef) { | ||
| $subObject = $this->getPropertyValue($ref, $object, $propRef->getName()); | ||
|
|
||
| $registeredTags = $this->guessObjectsTags($subObject, $prefix, $excludedClasses, $registeredTags); |
There was a problem hiding this comment.
is there a possible embedded requests edge case ?
sidux
force-pushed
the
improve-cache-invalidation
branch
from
b8729a3
to
2d77187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.