Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Excel] (Custom Functions) Add unified manifest note to all articles #4824

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

alison-mk
Copy link
Contributor

No description provided.

Copy link
Contributor

Learn Build status updates of commit 3d88203:

💡 Validation status: suggestions

File Status Preview URL Details
docs/includes/excel-custom-functions-note.md 💡Suggestion View Details
docs/quickstarts/excel-quickstart-react.md ✅Succeeded View
docs/tutorials/excel-tutorial.md ✅Succeeded View

docs/includes/excel-custom-functions-note.md

  • Line 17, Column 225: [Suggestion: learn-site-link-broken - See documentation] Link '/develop/add-in-manifests.md' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

# [Unified manifest for Microsoft 365](#tab/jsonmanifest)

> [!NOTE]
> The unified manifest for Microsoft 365 is currently in public developer preview and shouldn't be used in production add-ins. We invite you to try it out in test or development environments. Use the add-in only manifest for production add-ins.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to modify this wording. It's only preview for WXP. It's GAed for Outlook.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I updated the wording.

Copy link
Contributor

Learn Build status updates of commit a3daa08:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit a3daa08050824fb1fadf7ef695103e7948569712 in branch alison-mk-cf-unified-manifest of repository https://github.com/OfficeDev/office-js-docs-pr into branch main (commit c5db38481b1a4febac20f70dcde036d0b6d7c10f). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit fab97ca:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit fab97cafc87bf2a24a70df0fcc524c32d8f6c04e in branch alison-mk-cf-unified-manifest of repository https://github.com/OfficeDev/office-js-docs-pr into branch main (commit c5db38481b1a4febac20f70dcde036d0b6d7c10f). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Rick-Kirkham Rick-Kirkham self-requested a review October 4, 2024 22:44
Copy link
Contributor

Learn Build status updates of commit 67ad913:

✅ Validation status: passed

File Status Preview URL Details
docs/includes/excel-custom-functions-note.md ✅Succeeded View
docs/quickstarts/excel-quickstart-react.md ✅Succeeded View
docs/tutorials/excel-tutorial.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants