-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add filters for gt labelling and gt script-type #88
Conversation
The code itself looks fine, but there a some accessibility concerns:
I would suggest to check with the WAVE browser extension. Also, lots of Vue warnings are logged to the console about missing props, extraneous non-props attributes and missing translations. This should be investigated. |
Thanks for the extensive review.
|
Selected items in the dropdowns have a contrast ratio of 2.55 or lower, while WCAG AA requires at least 4.5 for normal-sized text. In general, the blue is too light, especially on a colored background. |
Ah, thanks, I see. As we didn't put much thought into coloring yet, these are just default color stylings from the |
closes #68