Quiver Tab "Projects" selected although Tab "Workflow" is opened #65
Conversation
| function onTabChange({ index }) { | ||
| router.push(items.value[index].to) | ||
| } | ||
| const activeRouteIndex = computed({ |
There was a problem hiding this comment.
We also have to consider that the URL stays the same which shouldn't be the case. I think the solution should be to redirect the route to /workflows before loading the tabs. Then the tabs would pick up the right path automatically.
There was a problem hiding this comment.
I'm not really sure about the issue, could you please elaborate further?
There was a problem hiding this comment.
When you visit the app initially it stays on /. But in fact it is /workflows, so it should redirect the URL to /workflows. After that you should pass the index to the TabMenu. So the getter here becomes simpler. That way the tabs would always stay in sync with the URL.
There was a problem hiding this comment.
Okay, I've updated it. Can you check it out?
|
@paulpestov Can you check this pull request and merge if there's no issues? I still don't have write access to the repository |
Closes #57