Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust the styling of dropdown and multiselect components to match the theme #102

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

jfrer
Copy link
Collaborator

@jfrer jfrer commented Jul 30, 2024

Previously there were the following issues:

  • 2/3 of the dropdown components still matched the old theme.
  • The document (GT) multiselect was still using the default multiselect, not the wrapper with a more accessible "select all" label.
  • The hover effect of the default styling applied a border color that matched the border color without hover, so the border color remained unchanged on hover.

This PR resolves these problems by removing unstyled mode for all dropdowns, using the multiselect wrapper and changing the border color on hover to a more visible color.

@jfrer jfrer requested a review from paulpestov July 30, 2024 13:03
@jfrer jfrer merged commit b76de06 into master Aug 6, 2024
1 check passed
@jfrer jfrer deleted the unify-dropdown-styling branch August 6, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants