Patch instant-vote bug #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents a bug that allows the suggester of an element to down-vote then quickly remove their down-vote, leading to the element getting voted in at one below the required number
Nv7-GitHub
requested changes
Feb 20, 2023
| b.deletePoll(&p, s) | ||
| return | ||
| } | ||
|
|
||
| // Handle | ||
| if r.Emoji.Name == UpArrow { |
There was a problem hiding this comment.
These changes aren't persisted until line 52, so it wouldn't make a difference. Perhaps move the "User trying to delete?" code below the UPDATE statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a bug that allows the suggester of an element to down-vote then quickly remove their down-vote, leading to the element getting voted in at one below the required number