Add dashboard #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdelboca
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Looks good @avdata99 !
Two things:
- I would rather have SQLAlchemy expressions rather than separated SQL files. This can be changed in a future. Any reason you chose raw sql over sqlalchemy?
- I think that a small improvement could be to change the order of statistics from
365 30 7to7 30 365. I guess the most dynamic report is the Last 7 days so It would make sense to not need to scroll down everytime. Maybe @nadineisabel can expand if she see the current order as an issue or not.
|
@pdelboca They are some SQLALchemy queries (the newer ones). The older ones uses sql queries. |
|
@pdelboca thanks! Yes I agree, would be great to see latest to oldest in terms of order. |
|
Issue created to change the stats order #8 |
|
@nadineisabel I linked this repository to our GitHub project and added these two new issues for next sprint as P1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the data collected from this extension in a new dashboard (based on CKAN internal
stats)