Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Update #5

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Readme Update #5

merged 5 commits into from
Nov 8, 2024

Conversation

avdata99
Copy link
Collaborator

@avdata99 avdata99 commented Nov 5, 2024

This PR defines a more informative README before publising the extension

The new version is visible here https://github.com/NorwegianRefugeeCouncil/ckanext-tracking/blob/new_readme/README.md

Copy link
Collaborator

@pdelboca pdelboca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README looks good @avdata99 ! I left a small comment in one paragraph.

README.md Outdated Show resolved Hide resolved
@pdelboca pdelboca self-requested a review November 6, 2024 07:03
Copy link
Collaborator

@pdelboca pdelboca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I'm wondering. We are using tracking as the name of the extension which is fine since we developed it targeting CKAN 2.10. However, in CKAN 2.11 we extracted tracking into it's own core extension ckan/ckan#7772.

We should rename this extension to something like api-tracking so it doesn't create conflicts when upgrading to CKAN 2.11.

Co-authored-by: Patricio Del Boca <[email protected]>
@avdata99
Copy link
Collaborator Author

avdata99 commented Nov 8, 2024

@pdelboca issue created to rename this extension #7
Merging this, we can do a final review before publishing the extension

@avdata99 avdata99 merged commit 3d00ec6 into main Nov 8, 2024
2 checks passed
@avdata99 avdata99 deleted the new_readme branch November 8, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants