Final-Release: use a more descriptive git tag #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a more descriptive git tag for the release. The problem with a `24.05`-style tag is, that they *will* land in peoples pinned sources - and those people will wonder why they never get any updates. This changes hopes to make this less prevalent by adding a more descriptive name for the actual git tag: It tags the branch-off for the new channel release, but it is *not* the actual channel.
Closed
RossComputerGuy
approved these changes
Oct 30, 2024
wegank
reviewed
Oct 30, 2024
| @@ -141,7 +141,7 @@ export NEWVER=23.05 | |||
| 1. Find the commit id and tag the release **on the release branch**: | |||
|
|
|||
| ```bash | |||
| git tag --annotate --message="Release $NEWVER" $NEWVER <COMMIT_ID> | |||
| git tag --annotate --message="Release $NEWVER" "branch-off-$NEWVER" <COMMIT_ID> | |||
There was a problem hiding this comment.
Suggested change
| git tag --annotate --message="Release $NEWVER" "branch-off-$NEWVER" <COMMIT_ID> | |
| git tag --annotate --message="Release $NEWVER" "$NEWVER-branch-off" <COMMIT_ID> |
I guess I'm preferring 24.11-branch-off to branch-off-24.11, but I'll let @RossComputerGuy decide.
There was a problem hiding this comment.
I think branch-off-24.11 is better because we have release-24.11 so it would be consistent.
wegank
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a more descriptive git tag for the release.
The problem with a
24.05-style tag is, that they will land in peoples pinned sources - and those people will wonder why they never get any updates.This changes hopes to make this less prevalent by adding a more descriptive name for the actual git tag: It tags the branch-off for the new channel release, but it is not the actual channel.