Update to not use direct pushes anymore #70
Conversation
infinisil
changed the title
| git push upstream master release-$NEWVER $NEWVER-beta staging-$NEWVER staging-next-$NEWVER | ||
| git push upstream release-$NEWVER $NEWVER-beta staging-$NEWVER staging-next-$NEWVER |
There was a problem hiding this comment.
Not sure why master is included here, seems like a mistake since this section is about the release branch.
And btw, new branches don't count as directly pushed commits under GitHub, and neither do tags, so this works fine
There was a problem hiding this comment.
If it's not pushed to master, we lose the beta tag on the next master commit objects, don't we?
There was a problem hiding this comment.
Oh TIL that tag objects are an actual thing and not just a pointer to Git commits. Will need some thought
|
All -S are lost in this PR, can you comment on whether this is intentional (i.e. you propose to drop -S) or it is implicit to keep doing them, in that case, I think we should provide alternative instructions. |
|
@zimbatm @RaitoBezarius @figsoda: What specific branch protections were turned off to make the release work? And were they turned on again afterwards? |
The section effectively said to use PR's already, but it still had a reference to a command that indicated a direct push should be used. There's no need to do that, a pull request is totally fine.
This comes out of a discussion on Matrix with @RaitoBezarius, related to NixOS/rfcs#156