Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages: remove unused arguments #330312

Merged
merged 1 commit into from
Jul 31, 2024
Merged

python3Packages: remove unused arguments #330312

merged 1 commit into from
Jul 31, 2024

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 27, 2024 •
edited
Loading

Description of changes

Huge forwards step

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient force-pushed the python-modules-remove-unused-args branch 5 times, most recently from a29be8c to 18de9f8 Compare July 27, 2024 13:06
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 27, 2024
@Sigmanificient Sigmanificient marked this pull request as ready for review July 27, 2024 15:50
@Sigmanificient
Copy link
Member Author

Not sure why ofborg says it rebuilds x86_64-linux nixpkgs-manual

@Aleksanaa
Copy link
Member

See #311459 (comment), seems caused by nixpkgs-manual refactoring, should be safe to ignore

@Sigmanificient Sigmanificient force-pushed the python-modules-remove-unused-args branch from a49f1f9 to 204e777 Compare July 30, 2024 12:57
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Jul 30, 2024
@Aleksanaa
Copy link
Member

0 rebuilds now!

@Aleksanaa Aleksanaa merged commit 710c0b2 into NixOS:master Jul 31, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sigmanificient @Aleksanaa @SuperSandro2000