Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vatprism: init at 0.3.5 #329794

Merged
merged 2 commits into from
Jul 28, 2024
Merged

vatprism: init at 0.3.5 #329794

merged 2 commits into from
Jul 28, 2024

Conversation

ThePuzzlemaker
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ThePuzzlemaker ThePuzzlemaker changed the title Add vatprism Add vatprism at 0.3.5 Jul 25, 2024
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jul 25, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 25, 2024
@ThePuzzlemaker ThePuzzlemaker changed the title Add vatprism at 0.3.5 vatprism: init at 0.3.5 Jul 25, 2024
eclairevoyant
eclairevoyant previously requested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Some feeback below:

pkgs/by-name/va/vatprism/package.nix Show resolved Hide resolved
pkgs/by-name/va/vatprism/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/va/vatprism/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/va/vatprism/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/va/vatprism/package.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@ThePuzzlemaker
Copy link
Contributor Author

Everything should be fixed now. I figured I'd add a desktop entry while I was at it.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 25, 2024
@eclairevoyant eclairevoyant dismissed their stale review July 25, 2024 23:00

changes addressed

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 329794 run on x86_64-linux 1

2 packages built:
  • nixpkgs-manual
  • vatprism

JohnRTitor
JohnRTitor approved these changes Jul 27, 2024
View reviewed changes
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and ran successfully.

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 329794 run on aarch64-linux 1

1 package built:
  • vatprism

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 329794 run on x86_64-linux 1

2 packages built:
  • nixpkgs-manual
  • vatprism

JohnRTitor
JohnRTitor approved these changes Jul 28, 2024
View reviewed changes
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on both x64 and aarch64 linux

@JohnRTitor JohnRTitor merged commit 8c4fe10 into NixOS:master Jul 28, 2024
26 of 28 checks passed
@ThePuzzlemaker ThePuzzlemaker deleted the add-vatprism branch July 31, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnRTitor JohnRTitor JohnRTitor approved these changes

@infinisil infinisil infinisil left review comments

@eclairevoyant eclairevoyant Awaiting requested review from eclairevoyant

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ThePuzzlemaker @JohnRTitor @eclairevoyant @infinisil @NixOSInfra