Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODEOWNERS: remove samueldr #323228

Merged
merged 1 commit into from
Jun 29, 2024
Merged

CODEOWNERS: remove samueldr #323228

merged 1 commit into from
Jun 29, 2024

Conversation

eclairevoyant
Copy link
Contributor

@eclairevoyant eclairevoyant commented Jun 28, 2024 •
edited
Loading

Description of changes

Followup to #321436 that ensures the CODEOWNERS file is valid again. Presumably samueldr left as a committer as well, hence GH considers the file invalid.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 28, 2024
@eclairevoyant eclairevoyant added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 29, 2024
@eclairevoyant eclairevoyant merged commit 37835a7 into NixOS:master Jun 29, 2024
23 of 24 checks passed
@eclairevoyant eclairevoyant deleted the remove-samueldr branch June 29, 2024 03:36
@MattSturgeon MattSturgeon mentioned this pull request Jun 29, 2024
Merged
6 tasks
@piegamesde
Copy link
Member

Presumably samueldr left as a committer

I've heard that @zimbatm has an explanation for this

@zimbatm
Copy link
Member

zimbatm commented Jun 30, 2024

Yes, let me write a quick transparency report.

@zimbatm
Copy link
Member

zimbatm commented Jun 30, 2024

See NixOS/org#12

@eclairevoyant eclairevoyant added the backport release-24.05 Backport PR automatically label Jul 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Jul 5, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusramberg marcusramberg marcusramberg approved these changes

@katexochen katexochen Awaiting requested review from katexochen

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eclairevoyant @piegamesde @zimbatm @marcusramberg