hercules-ci-{agent,cnix-expr}: Force use of propagated boehmgc #146388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already in effect, but only by coincidence. A direct boehmgc could presumably be added implicitly in the generated code by fixing the pkg-config to nixpkgs mapping. This commit should counteract that, or, in case of a rename, cause an evaluation error so that it can be fixed, instead of building and crashing at runtime.
roberth
requested review from
cdepillabout,
expipiplus1,
maralorn and
sternenseemann
as code owners
|
Do you mind opening an issue about the incorrect handling of |
sternenseemann
approved these changes
Nov 17, 2021
|
@sternenseemann done: NixOS/cabal2nix#529 I don't think we have an actual use case for it though. |
|
Well, I've accidentally learned that the bdw-gc dependency isn't necessary in the cabal file either. I'm removing the bdw-gc reference in 0.9, so this change won't be necessary (and need to be reverted). I'm glad we can keep it simple, which is the best outcome. Sorry for the noise. |
roberth
added a commit
to hercules-ci/hercules-ci-agent
that referenced
this pull request
Jan 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already in effect, but only by coincidence. A direct
boehmgc could presumably be added implicitly in the generated
code by fixing the pkg-config to nixpkgs mapping.
This commit should counteract that, or, in case of a rename,
cause an evaluation error so that it can be fixed, instead of
building and crashing at runtime.
Motivation for this change
Make hercules-ci-cnix-expr and hercules-ci-agent packages robust against a potentially disastrous cabal2nix improvement.
bdw-gc = nullin the generated hackage-packages code is technically a bug, but required for nix bindings to work correctly.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)