-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flakes: split sources #805
base: main
Are you sure you want to change the base?
Conversation
68d57f8
to
4ec60c1
Compare
4ec60c1
to
834500d
Compare
834500d
to
aeae7bf
Compare
aeae7bf
to
84a7ae2
Compare
84a7ae2
to
de58530
Compare
de58530
to
818ed9a
Compare
818ed9a
to
f97d437
Compare
f97d437
to
f970611
Compare
f970611
to
76ab1a2
Compare
76ab1a2
to
7d6ea20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry this took me so long to take a look at.
I really like the direction this is going. This does however only address the PR checks and not the actual import. That would be where the actual issues surface when a downstream flake breaks. So I think we should loop over the groups in the import as well, write them to a yaml (maybe? it should at least be concat'able) and bulk-import that into ES.
I've also lost track of the PR, but I think the one-line change in |
7d6ea20
to
51e81a7
Compare
This PR splits
flakes/manual.toml
into multiple files underflakes/manual/
, and modifies.github/workflows/check-flake-files.yml
so that it only runs on the modified files.