Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/nvidia disable: Remove lib.mkDefault #692

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

Lyndeno
Copy link
Contributor

@Lyndeno Lyndeno commented Aug 8, 2023

Description of changes

Adjust Nvidia disable module to match with CONTRIBUTING.md guidelines. Specifically to remove lib.mkDefault on options we would want to allow merging user config with.

Another PR performing this change treewide may be beneficial.

Related to #691

Fixes #607

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@Mic92 Mic92 merged commit 1b3c128 into NixOS:master Aug 9, 2023
1 check passed
@Lyndeno Lyndeno deleted the nvidia-disable-fix branch August 9, 2023 14:17
Lyndeno added a commit to Lyndeno/nixos-hardware that referenced this pull request Jul 2, 2024
This is my daily driver and I foresee this to be the case for a long
while.

Contributions directly to this model:
- NixOS#691
- NixOS#696

Contributions indirectly affecting this model:
- NixOS#692
@Lyndeno Lyndeno mentioned this pull request Jul 2, 2024
2 tasks
Lyndeno added a commit to Lyndeno/nixos-hardware that referenced this pull request Jul 2, 2024
This is my daily driver and I foresee this to be the case for a long
while.

Contributions directly to this model:
- NixOS#691
- NixOS#696

Contributions indirectly affecting this model:
- NixOS#692
mergify bot pushed a commit that referenced this pull request Jul 19, 2024
This is my daily driver and I foresee this to be the case for a long
while.

Contributions directly to this model:
- #691
- #696

Contributions indirectly affecting this model:
- #692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvidia/disable.nix isn't working as expected
2 participants